[PATCH] D118094: [ValueTracking] Checking haveNoCommonBitsSet for (x & y) and ~(x | y)

[Chuanqi Xu via Phabricator via llvm-commits]

ChuanqiXu marked an inline comment as done.
ChuanqiXu added inline comments.


================
Comment at: llvm/unittests/Analysis/ValueTrackingTest.cpp:1760
+    %RHS2 = xor i32 %or2, -1
+    %Add2 = add i32 %LHS, %RHS
+
----------------
spatel wrote:
> Should %Add2 use %LHS2 and %RHS2? I don't think it changes anything for the EXPECT lines below, but it is confusing. Could remove all of the add instructions completely?
Thanks. It looks odd to me if the value is not used... but fine it is test case after all.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118094/new/

https://reviews.llvm.org/D118094