[PATCH] D119307: [Bitstream] Fix UB in left-shift in ReadVBR

Jan Korous via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 14 18:28:08 PST 2022


jkorous added a comment.

I noticed `ReadVBR64` method below does the same arithmetics and keeping the implementation in sync seems like a no-brainer.

Ultimately the error message propagation is unrelated to the assert but it does seem like a minor improvement - I'll just land it as a separate commit.

I plan to land this tomorrow unless there's some additional feedback.

Thank you both for the opportunity to learn a bit about this part of llvm-project! :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119307/new/

https://reviews.llvm.org/D119307



More information about the llvm-commits mailing list