[PATCH] D119787: [ELF][PPC64] Fix assertion failure for branches to hidden undefined weak for -no-pie

Mon Feb 14 14:58:36 PST 2022

MaskRay added a comment.

@stefanp I use this opportunity to clean up some tests, so I have created a new patch.

ppc64 psABI may want to clarify the behavior (aarch64 psABI defines the behavior for a branch to an undefined weak, though I think "branch to the next instruction" is a bad choice).
I have documented what I know in https://maskray.me/blog/2021-04-25-weak-symbol#branch-relocations

I find that GNU ld's powerpc64 port may change the `bl` instruction to `nop` in some cases. I think that is not great, either, since the run-time undefined behavior (branch to undefined weak) is not detected.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119787/new/

https://reviews.llvm.org/D119787