[PATCH] D119368: [UpdateLLCTestChecks] Add support for isel debug output in update_llc_test_checks.py

Yatao Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 14 13:57:49 PST 2022


ningxinr added inline comments.


================
Comment at: llvm/utils/UpdateTestChecks/isel.py:33-40
+def get_triple_from_march(march):
+  triples = {
+   }
+  for prefix, triple in triples.items():
+    if march.startswith(prefix):
+      return triple
+  print("Cannot find a triple. Assume 'x86'", file=sys.stderr)
----------------
Flakebi wrote:
> Does it make sense to put `get_triple_from_march` into common.py or update_llc_test_checks.py? It doesn’t look isel or asm specific.
Yes. I have moved `get_triple_from_march` into common.py.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119368/new/

https://reviews.llvm.org/D119368



More information about the llvm-commits mailing list