[PATCH] D119770: [libcxx] Fix the type in __estimate_column_width

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 14 13:13:34 PST 2022


hubert.reinterpretcast accepted this revision.
hubert.reinterpretcast added a comment.

`__utf32_character` guards against usage of 16-bit `wchar_t`. The usage that gets broken by using `wchar_t` in the implementation is the `char32_t` case. There's no reason to tie the `char32_t` case to a UTF-32 `wchar_t` that I know of. The change LGTM.

Please wait for approval from the libc++ group.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119770/new/

https://reviews.llvm.org/D119770



More information about the llvm-commits mailing list