[PATCH] D115973: [llvm-profgen] Support symbol loading for debug fission

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

Did you read jhenderson's point?

> 1. yaml2obj with DWARF, if the support is sufficiently mature for your use-case, and the output is easy enough to read - one advantage with DWARF yaml2obj is that you can omit many of the required fields, unlike assembly, so depending on the complexity you need, this may be a better option for long-term maintenance.

The tests are clumsy. I don't think we should land the change as is. 
`split-dwarf-split.exe.yaml` has nearly 800 lines and includes many tags which are not needed for the purpose of the test. For example, all the STT_SECTION symbols, .eh_frame, .init_array, and .dynsym can be deleted.
The `.debug_*` sections are opaque and difficult to maintain.
If the readability of `split-dwarf-split.exe.yaml` cannot be improved after some cleanups, try leaving a small stub test and consider adding the fullblown test (simplification still required) in cross-project-tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115973/new/

https://reviews.llvm.org/D115973