[PATCH] D119630: [WebAssembly] Use GeneralDynamic TLS for exception handling builtins.

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 14 12:22:09 PST 2022


sbc100 added a comment.

In D119630#3320208 <https://reviews.llvm.org/D119630#3320208>, @aheejin wrote:

>> These global TLS symbols are shared across all shared libraries and cannot be assumed to be local to the currently module.
>
> Is there any other libraries other than compiler-rt with which these variables are shared?

No, as afar as I know system/lib/compiler-rt/emscripten_exception_builtins.c is the only place these get defined or used aside from in this code here.

>> Fixes: https://github.com/emscripten-core/emscripten/issues/1339



> I think the link is incorrect? That issue is from 2013.

Oops I was missing an 8: https://github.com/emscripten-core/emscripten/issues/13398


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119630/new/

https://reviews.llvm.org/D119630



More information about the llvm-commits mailing list