[PATCH] D119698: [flang] Lower basic function with scalar integer/logical return value

[Valentin Clement via Phabricator via llvm-commits]

clementval added inline comments.


================
Comment at: flang/include/flang/Lower/CallInterface.h:113
+    /// Position of related passedEntity in passedArguments.
+    /// (passedEntity is the passedResult this value is resultEntityPosition.
+    int passedEntityPosition;
----------------
kiranchandramohan wrote:
> Nit: closing ')'. I think this is for input arguments only?
-1 is passed for the result position. Of course it is mostly used later for the args.


================
Comment at: flang/lib/Lower/Bridge.cpp:246
 
+    mlir::Value primaryFuncResultStorage;
     for (const Fortran::lower::pft::Variable &var :
----------------
kiranchandramohan wrote:
> Where is this used?
Not used right now. Removed from this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119698/new/

https://reviews.llvm.org/D119698