[PATCH] D119482: [OpaquePtr][LLParser] Automatically detect opaque pointers in .ll files

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

I'm not really convinced by this. I think automatically going into opaque pointer mode if `ptr` is mentioned in `.ll` makes some sense, but I'm not a fan on determining the mode based on first constructed pointer. For bitcode, we can embed a marker for opaque pointer mode rather than guessing.



================
Comment at: llvm/include/llvm/IR/LLVMContext.h:309
-  /// pointer type.
-  void enableOpaquePointers() const;
-
----------------
Why drop this? This is needed for per-frontend enablement, which we'll still need, right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119482/new/

https://reviews.llvm.org/D119482