[PATCH] D119381: [MTE] Add NT_ANDROID_TYPE_MEMTAG

[Mitch Phillips via Phabricator via llvm-commits]

hctim marked 9 inline comments as done.
hctim added inline comments.


================
Comment at: llvm/include/llvm/BinaryFormat/ELF.h:1536-1537
+enum {
+  NT_ANDROID_TYPE_IDENT = 1,
+  NT_ANDROID_TYPE_KUSER = 3,
+  NT_ANDROID_TYPE_MEMTAG = 4,
----------------
jhenderson wrote:
> I guess the `2` value isn't used?
Negative (https://cs.android.com/android/platform/superproject/+/master:bionic/libc/private/bionic_asm_note.h)


================
Comment at: llvm/include/llvm/BinaryFormat/ELF.h:1546-1547
+  NT_MEMTAG_LEVEL_MASK = 3,
+  NT_MEMTAG_HEAP = 4,
+  NT_MEMTAG_STACK = 8,
+};
----------------
jhenderson wrote:
> I guess values 5-7 aren't used?
`NT_MEMTAG_LEVEL_*` are enum values, any `NT_MEMTAG_HEAP/STACK` are bitsets. Added some clarifying comments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119381/new/

https://reviews.llvm.org/D119381