[PATCH] D118416: [Metadata] Use temporary MD nodes when appending module flags during module linking

Duncan P. N. Exon Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 14 11:01:55 PST 2022


dexonsmith added a comment.

In D118416#3291434 <https://reviews.llvm.org/D118416#3291434>, @wolfgangp wrote:

> Thanks for looking into this.
>
> It seems best to abandon the proposed change and introduce a resize() capability for MDNodes.
>
> Not being all that intimately familiar with MD, I might have some silly questions later on.

(A bit behind on reviews); sounds great! I think the main gotcha is that an MDNode in a "uniqued" state shouldn't be resizable since it's constant-like.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118416/new/

https://reviews.llvm.org/D118416



More information about the llvm-commits mailing list