[PATCH] D119705: [flang] Fix `LoweringBridge::validModule`

Eric Schweitz via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 14 09:04:23 PST 2022


schweitz added inline comments.


================
Comment at: flang/include/flang/Lower/Bridge.h:87
 
-  bool validModule() { return getModule(); }
+  bool validModule() { return (nullptr != module); }
 
----------------
Someone else called this "Yoda style". But their question remains: why use it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119705/new/

https://reviews.llvm.org/D119705



More information about the llvm-commits mailing list