[llvm] d462e64 - [LV] Drop noalias from check lines from test (NFC).

[Florian Hahn via llvm-commits]

On Mon, Feb 14, 2022 at 4:29 PM Nikita Popov <nikita.ppv at gmail.com> wrote:

> On Sun, Feb 13, 2022 at 12:37 PM Florian Hahn via llvm-commits <
> llvm-commits at lists.llvm.org> wrote:
>
>>
>> Author: Florian Hahn
>> Date: 2022-02-13T11:36:54Z
>> New Revision: d462e647542dc54718a4a4dfa6476b3dd2649a13
>>
>> URL:
>> https://github.com/llvm/llvm-project/commit/d462e647542dc54718a4a4dfa6476b3dd2649a13
>> DIFF:
>> https://github.com/llvm/llvm-project/commit/d462e647542dc54718a4a4dfa6476b3dd2649a13.diff
>>
>> LOG: [LV] Drop noalias from check lines from test (NFC).
>>
>> The noalias metadata checks re not really relevant for the test and
>> slight changes to metadata numbering can have large knock-on effects
>> causing large noise in test diff.
>>
>
> Manually dropping the metadata causes even more noise to appear the next
> time someone runs update_test_checks on this file. Please avoid manually
> editing UTC-generated files in this way. If metadata does not add value to
> this test, then I'd recommend adding a new --scrub-metadata or similar flag
> to UTC (to complement --scrub-attributes), which allows dropping irrelevant
> information while preserving the automation.
>
>>

Thanks, I'll use the flag nex time.

FWIW auto-generating check lines for tests like this one isn't great in the
first place IMO, because small changes to the output cause a huge amount of
noise. It's easier to update, but makes it much harder to review changes :(

Is there a flag for update_test_checks.py to avoid regenerating check lines
if only value numbering changes in a sub-region?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220214/389b1866/attachment.html>