[PATCH] D119453: [AArch64] Suggest b.nfrst if the user tries b.nfirst.

Mon Feb 14 08:39:35 PST 2022

peterwaller-arm accepted this revision.
peterwaller-arm added a comment.

LGTM with one more consistency tweak.

================
Comment at: llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp:3092
+    if (!Suggestion.empty())
+      Msg += ". Did you mean '" + Suggestion + "'?";
+    return TokError(Msg);
----------------
Thanks for the patch. Sorry, I think another pass is needed here for consistency, the messages look like so (no quotes, single sentence):

https://github.com/llvm/llvm-project/blob/779bbbf27fe631154bdfaac7a443f198d4654688/llvm/utils/TableGen/AsmMatcherEmitter.cpp#L3091

```
test/MC/AArch64/invalid-instructions-spellcheck.s
28:// CHECK:      error: unrecognized instruction mnemonic, did you mean: add, addp, adds, addv, fadd, madd?
35:// CHECK-NO-NEON:      error: unrecognized instruction mnemonic, did you mean: add, adds, fadd, madd?
```

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119453/new/

https://reviews.llvm.org/D119453