[PATCH] D119698: [flang] Lower basic function with scalar integer/logical return value

[Pete Steinfeld via Phabricator via llvm-commits]

PeteSteinfeld accepted this revision.
PeteSteinfeld added a comment.
This revision is now accepted and ready to land.

Aside from one nit, all builds and tests correctly and looks good.



================
Comment at: flang/lib/Lower/ConvertType.cpp:220-221
+        int kind = toInt64(Fortran::common::Clone(tySpec->kind())).value();
+        // llvm::SmallVector<Fortran::lower::LenParameterTy> params;
+        // translateLenParameters(params, tySpec->category(), ultimate);
+        ty = genFIRType(context, tySpec->category(), kind);
----------------
Are these lines supposed to be here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119698/new/

https://reviews.llvm.org/D119698