[PATCH] D118094: [ValueTracking] Checking haveNoCommonBitsSet for (x & y) and ~(x | y)

[Sanjay Patel via Phabricator via llvm-commits]

spatel added inline comments.


================
Comment at: llvm/unittests/Analysis/ValueTrackingTest.cpp:1760
+    %RHS2 = xor i32 %or2, -1
+    %Add2 = add i32 %LHS, %RHS
+
----------------
Should %Add2 use %LHS2 and %RHS2? I don't think it changes anything for the EXPECT lines below, but it is confusing. Could remove all of the add instructions completely?


================
Comment at: llvm/unittests/Analysis/ValueTrackingTest.cpp:1780
+  {
+    // Check for (A & B) and ~(A | B) in vetcor version
+    auto M = parseModule(R"(
----------------
Typo: "vector"


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118094/new/

https://reviews.llvm.org/D118094