[PATCH] D119557: [Systemz/z/OS] Centralize emitting the call type information

Ulrich Weigand via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 14 05:49:45 PST 2022


uweigand accepted this revision.
uweigand added a comment.
This revision is now accepted and ready to land.

See inline comment.  Otherwise this LGTM.



================
Comment at: llvm/lib/Target/SystemZ/SystemZAsmPrinter.cpp:127
 
+void SystemZAsmPrinter::emitCallInformation(CallType CT) {
+  EmitToStreamer(*OutStreamer,
----------------
Minor nit: this function could use a comment explaining that it is deliberately emitting a NOP instruction that encodes information into the register used, in accordance with the XPLINK ABI.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119557/new/

https://reviews.llvm.org/D119557



More information about the llvm-commits mailing list