[PATCH] D119623: [SLP] Simplify indices processing for insertelements

[Alexey Bataev via Phabricator via llvm-commits]

ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.

LG



================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:4026
         SourceVectors.insert(cast<Instruction>(V)->getOperand(0));
-        Optional<int> Idx = *getInsertIndex(V);
-        if (!Idx || *Idx == UndefMaskElem)
-          continue;
-        MinIdx = std::min(MinIdx, *Idx);
+        if (getInsertIndex(V) == None) {
+          LLVM_DEBUG(dbgs() << "SLP: Gather of insertelement vectors with "
----------------
anton-afanasyev wrote:
> ABataev wrote:
> > anton-afanasyev wrote:
> > > ABataev wrote:
> > > > With an early check for insertelements in tryVectorizePair this can be turned to an assert rather than check and schedule cancellation.
> > > Yes, done in D119679
> > Update this patch after D119679
> Hmm, conversely, D119679 is based on this patch.
Ok, do not forget to remove this check then.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119623/new/

https://reviews.llvm.org/D119623