[PATCH] D118441: Preserve aliasing info during memory intrinsics lowering

Evgeniy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 14 03:44:49 PST 2022


ebrevnov added a comment.

In D118441#3296826 <https://reviews.llvm.org/D118441#3296826>, @arsenm wrote:

> In D118441#3292872 <https://reviews.llvm.org/D118441#3292872>, @ebrevnov wrote:
>
>> In D118441#3289224 <https://reviews.llvm.org/D118441#3289224>, @arsenm wrote:
>>
>>> In D118441#3286321 <https://reviews.llvm.org/D118441#3286321>, @ebrevnov wrote:
>>>
>>>> In D118441#3283987 <https://reviews.llvm.org/D118441#3283987>, @arsenm wrote:
>>>>
>>>>> Needs some lit tests that show the metadata after expansion
>>>>
>>>> The problem is there is now pass which runs this utility. I'm not aware how to exercise it from lit test. For that reason I had to create a unit test. Is there a way to build a lit test in such case?
>>>
>>> AMDGPU uses this, see llvm/test/CodeGen/AMDGPU/lower-mem-intrinsics.ll
>>
>> In order for this to work I would need to modify AMDGPULowerIntrinsics pass to provide additional argument(result of ScalarEvolutionAnalysis) to expandMemCpyAsLoop. Currently, this pass doesn't depend on SCEV analysis.
>
> That's fine

Do you mean it's fine to modify AMDGPULowerIntrinsics pass? If that's what you mean I don't see there is enough rational to do a non NFC change just to be able to create a test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118441/new/

https://reviews.llvm.org/D118441



More information about the llvm-commits mailing list