[PATCH] D119679: [SLP] Don't try to vectorize pair with insertelement

[Anton Afanasyev via Phabricator via llvm-commits]

anton-afanasyev marked an inline comment as done.
anton-afanasyev added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:4046
 
+      // Prohibit external uses for intermediate inserts
+      // TODO: this could be allowed by shuffling vectorized value
----------------
ABataev wrote:
> anton-afanasyev wrote:
> > ABataev wrote:
> > > I would try to do this a bit earlier and simpler. Before calling `tryToVectorizePair` (or something like this) it is just enough to check that one of the instructions is insertelement. And just do not try vectorization in this case.
> > Ok, done this way. Though need to keep in mind other paths for inserts get to `buildTree()`.
> If there are other paths, just need to add a check there too, need to handle insertelements only from buildvector vectorization attempt.
There are no other paths for now, I meant, in future.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119679/new/

https://reviews.llvm.org/D119679