[PATCH] D119695: [Support] Fix build on illumos

[Rainer Orth via Phabricator via llvm-commits]

ro added inline comments.


================
Comment at: llvm/lib/Support/Unix/Path.inc:121
 
+#if defined(__sun__)
+// The madvise() declaration on Illumos cannot be made visible if _XOPEN_SOURCE
----------------
The canonical way to check for Solaris/Illumos is `defined(__sun__ && defined(__svr4__)`.

As issues like this don't come up for the first time, it would be extremely helpful if Illumos would provide a predefine to support that, something like `__illumos__` or whatever the community sees fit.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119695/new/

https://reviews.llvm.org/D119695