[PATCH] D119480: [AMDGPU] Improve clobbering checks in the kernel argument promotion

Valery Pykhtin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 10 14:10:09 PST 2022


vpykhtin added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/Utils/AMDGPUMemoryUtils.cpp:33
+
+  const auto isReallyAClobber = [AA, Load](MemoryDef *Def) -> bool {
+    Instruction *DefInst = Def->getMemoryInst();
----------------
This is usefull routine outside of the eclosing function, I would move it on the file scope and replace Load argument with its pointer, I don't see other uses of Load there.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119480/new/

https://reviews.llvm.org/D119480



More information about the llvm-commits mailing list