[PATCH] D119244: Cleanup LLVMMC headers

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

In D119244#3309062 <https://reviews.llvm.org/D119244#3309062>, @rastogishubham wrote:

> Hi it seems like this change might have been responsible for the lldb incremental bot to have broken
>
> /Users/buildslave/jenkins/workspace/lldb-cmake/host-compiler/bin/../include/c++/v1/__memory/unique_ptr.h:50:19: error: missing '#include "llvm/MC/MCSubtargetInfo.h"'; 'MCSubtargetInfo' must be defined before it is used
>
>   static_assert(sizeof(_Tp) > 0,
>                 ^
>
> /Users/buildslave/jenkins/workspace/lldb-cmake/host-compiler/bin/../include/c++/v1/__memory/unique_ptr.h:315:7: note: in instantiation of member function 'std::default_delete<llvm::MCSubtargetInfo>::operator()' requested here
>
>   __ptr_.second()(__tmp);
>   ^
>
> /Users/buildslave/jenkins/workspace/lldb-cmake/host-compiler/bin/../include/c++/v1/__memory/unique_ptr.h:269:19: note: in instantiation of member function 'std::unique_ptr<llvm::MCSubtargetInfo>::reset' requested here
>
>   ~unique_ptr() { reset(); }
>                   ^
>
> /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/include/llvm/DWARFLinker/DWARFStreamer.h:46:3: note: in instantiation of member function 'std::unique_ptr<llvm::MCSubtargetInfo>::~unique_ptr' requested here
>
>   DwarfStreamer(OutputFileType OutFileType, raw_pwrite_stream &OutFile,
>   ^
>
> /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/include/llvm/MC/MCSubtargetInfo.h:76:7: note: definition here is not reachable
> class MCSubtargetInfo {
>
>   ^
>
> /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/lib/DWARFLinker/DWARFLinkerCompileUnit.cpp:9:10: fatal error: could not build module 'LLVM_DWARFLinker'
> #include "llvm/DWARFLinker/DWARFLinkerCompileUnit.h"
>
> Build is here: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/41179/
>
> Please revert the change or fix it as soon as poosible, thanks

Is this a LLVM_ENABLE_MODULES=on build? For regular build `check-lldb` builds.

I added a possibly missing header to llvm/include/llvm/DWARFLinker/DWARFStreamer.h and am building a module build to confirm.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119244/new/

https://reviews.llvm.org/D119244