[PATCH] D119244: Cleanup LLVMMC headers

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 8 20:00:09 PST 2022


MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/include/llvm/MC/MCContext.h:48
+
+class CodeViewContext;
+class MCAsmInfo;
----------------
The clang-format should be done separately.


================
Comment at: llvm/include/llvm/MC/MCDwarf.h:33
 
+class MCSection;
+
----------------
move this below


================
Comment at: llvm/include/llvm/MC/MCLinkerOptimizationHint.h:27
 
+class raw_ostream;
 class MachObjectWriter;
----------------
sort


================
Comment at: llvm/include/llvm/MC/MCStreamer.h:41
+class APInt;
+class MCAssembler;
+class MCFragment;
----------------
Sort at least `MC*` declarations


================
Comment at: llvm/lib/MC/MCAssembler.cpp:44
 
+namespace llvm {
+class MCSubtargetInfo;
----------------
forward declarations are usually after `using namespace llvm;`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119244/new/

https://reviews.llvm.org/D119244



More information about the llvm-commits mailing list