[PATCH] D117253: [AMDGPU] Select VGPR versions of MFMA if possible

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 7 11:58:03 PST 2022


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/VOP3PInstructions.td:448
+class AgprMAIFrag<SDPatternOperator Op> :
+  MAIFrag<Op, [{ return MF->getInfo<SIMachineFunctionInfo>()->mayNeedAGPRs(); }]>;
+
----------------
rampitec wrote:
> arsenm wrote:
> > The point of checking it here is you don't need to inspect the original IR. You can check if there are any AGPR uses in the machine function
> This is selection, there MF is not yet selected. Plus it needs a check for calls.
We know if there are calls at selection time already, and have already lowered all asm and should have seen the AGPRs already


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117253/new/

https://reviews.llvm.org/D117253



More information about the llvm-commits mailing list