[PATCH] D119623: [SLP] Simplify indices processing for insertelements

[Anton Afanasyev via Phabricator via llvm-commits]

anton-afanasyev added a comment.

> Ok, got it. Could you also add a check to the buildvector detection function for such kind of insertelement (+ possibly insertvalue) instructions? They should not be treated as a part of buildvector, need to treat them as an initial/terminating instruction and exclude from possibly vectorizable buildvector instructions.

Do you mean `findBuildAggregate()`? This check is already there, see line 9603.



================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:9603
+        getInsertIndex(LastInsertInst, OperandOffset);
     if (!OperandIndex)
       return false;
----------------
@ABataev Do you mean this check?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119623/new/

https://reviews.llvm.org/D119623