[PATCH] D119559: [DAGCombine] Basic combines for AVG nodes.

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM with a couple of minors



================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:4690
+  }
+
+  // fold (avg x, undef) -> x
----------------
Please add a TODO comment for scalar (avg x, 0) patterns once we have test/type coverage?


================
Comment at: llvm/test/CodeGen/AArch64/hadd-combine.ll:664
   ret <8 x i16> %result
 }
 
----------------
Maybe make the undef src not v0.8h so we see the move ?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119559/new/

https://reviews.llvm.org/D119559