[PATCH] D119653: [NFC][RFC][TableGen] Improve the comment about variable len encoder
Sheng via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Feb 12 21:15:28 PST 2022
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGbf7f8d6fa6f4: [NFC][RFC][TableGen] Improve the comment about variable len encoder (authored by 0x59616e).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119653/new/
https://reviews.llvm.org/D119653
Files:
llvm/include/llvm/Target/Target.td
Index: llvm/include/llvm/Target/Target.td
===================================================================
--- llvm/include/llvm/Target/Target.td
+++ llvm/include/llvm/Target/Target.td
@@ -758,15 +758,15 @@
/// variable-length instruction encoding utilities.
/// The `ascend` operator should be used like this:
-/// (ascend 0b0000, 0b1111)
+/// (ascend 0b0010, 0b1101)
/// Which represent a seqence of encoding fragments placing from LSB to MSB.
-/// Thus, in this case the final encoding will be 0b11110000.
+/// Thus, in this case the final encoding will be 0b1101_0010.
/// The arguments for `ascend` can either be `bits` or another DAG.
def ascend;
/// In addition, we can use `descend` to describe an encoding that places
/// its arguments (i.e. encoding fragments) from MSB to LSB. For instance:
-/// (descend 0b0000, 0b1111)
-/// This results in an encoding of 0b00001111.
+/// (descend 0b0010, 0b1101)
+/// This results in an encoding of 0b0010_1101.
def descend;
/// The `operand` operator should be used like this:
/// (operand "$src", 4)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D119653.408234.patch
Type: text/x-patch
Size: 1084 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220213/ac3e22a3/attachment.bin>
More information about the llvm-commits
mailing list