[PATCH] D119079: [llvm] [cmake] Fix finding modern ounit2

Sat Feb 12 18:00:34 PST 2022

arbipher added a comment.

Hi all, I am happy to help with OCaml-related problems for this one and the future.
It seems I am a bit late to reply. I saw the email but didn't find a time to check this immediately at that moment until today.

I played with the ocaml binding several times before but not with the test.
@mgorny could you share the steps to run these ocaml tests against `ounit2-2.2.4`?

I tried `opam install llvm --with-test`, which uses llvm 13.0.1 and ounit2-2.2.5 on opam and it works.
This installation shows the unpatched cmake file works well with the ounit2 2.2.5. I would like to know the non-working scenario with your 2.2.4 without the pack.

The renaming of ounit2 occurs at 2.2.0 in 2019. See the release note <https://github.com/gildor478/ounit/releases/tag/v2.2.0>.
I am thinking maybe we could just support ounit2 in the trunk.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119079/new/

https://reviews.llvm.org/D119079