[PATCH] D89216: [dsymutil] Add the ability to run the DWARF verifier on the input

[Alexey Lapshin via Phabricator via llvm-commits]

avl added a comment.

Thank you Jonas! There are still several inline nits...



================
Comment at: llvm/include/llvm/DWARFLinker/DWARFLinker.h:787
 
+    /// Verify DWARF
+    bool VerifyInputDWARF = false;
----------------



================
Comment at: llvm/tools/dsymutil/LinkUtils.h:33
 
+  /// Verify DWARF
+  bool VerifyInputDWARF = false;
----------------



================
Comment at: llvm/tools/dsymutil/dsymutil.cpp:88
 
+enum class DWARFVerify : unsigned {
+  None = 0,
----------------



================
Comment at: llvm/tools/dsymutil/dsymutil.cpp:95
+
+inline DWARFVerify operator|(DWARFVerify LHS, DWARFVerify RHS) {
+  return static_cast<DWARFVerify>(static_cast<unsigned>(LHS) |
----------------
now it is not used and probably might be deleted.


================
Comment at: llvm/tools/dsymutil/dsymutil.cpp:100
+
+inline DWARFVerify operator&(DWARFVerify LHS, DWARFVerify RHS) {
+  return static_cast<DWARFVerify>(static_cast<unsigned>(LHS) &
----------------
now it is not used and probably might be deleted.


================
Comment at: llvm/tools/dsymutil/dsymutil.cpp:105
+
+inline bool FlagIsSet(DWARFVerify Flags, DWARFVerify SingleFlag) {
+  return static_cast<uint8_t>(Flags) & static_cast<uint8_t>(SingleFlag);
----------------
should start from the small letter.


================
Comment at: llvm/tools/dsymutil/dsymutil.cpp:248
+    if (S == "all")
+      return DWARFVerify::Input | DWARFVerify::Output;
+    if (S == "none")
----------------



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89216/new/

https://reviews.llvm.org/D89216