[PATCH] D118216: [RISCV] LUI used for address computation should not isAsCheapAsAMove

Ben Shi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Feb 12 05:10:18 PST 2022


benshi001 added a comment.

In D118216#3316752 <https://reviews.llvm.org/D118216#3316752>, @jrtc27 wrote:

> I objected and still believe this patch is fundamentally wrong. The problem needs solving elsewhere, not like this. Please revert.

Although this solution is far from perfect, it does improve code quality. Could you please show a test case that gets wrong or worse assembly by this patch?
I suggest we can keep it and go on searching better solutions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118216/new/

https://reviews.llvm.org/D118216



More information about the llvm-commits mailing list