[PATCH] D119614: [HWASAN] use common alignAndPadAlloca

Florian Mayer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 11 20:05:47 PST 2022


fmayer planned changes to this revision.
fmayer added a comment.

In D119614#3316412 <https://reviews.llvm.org/D119614#3316412>, @fmayer wrote:

> I am also looking whether this code in Aarch64StackTagging needs changing or whether there are different constraints (because HWASAN does more changes to debug intrinsics)
>
>   // Fixup debug intrinsics to point to the new alloca.
>   for (auto DVI : Info.DbgVariableIntrinsics)
>     DVI->replaceVariableLocationOp(Info.OldAI, Info.AI)
>
> If we only use this code for HWASAN, IR regression tests (alloca.ll and dbg-value-tag-offset.ll) fail.

Actually, I need to look more at this now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119614/new/

https://reviews.llvm.org/D119614



More information about the llvm-commits mailing list