[PATCH] D119606: [HWASAN] regression test we do not instrument dynamic allocas

Andrew via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 11 17:30:07 PST 2022


browneee accepted this revision.
browneee added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/test/Instrumentation/HWAddressSanitizer/alloca-uninteresting.ll:5
+; RUN: opt < %s -passes=hwasan -S | FileCheck %s --check-prefixes=CHECK
+
+target datalayout = "e-m:e-i8:8:32-i16:16:32-i64:64-i128:128-n32:64-S128"
----------------
nit: I suggest a comment to explain the purpose of the test. e.g.

Test that no instrumentation is added for a dynamic sized alloca, which are not instrumented because ...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119606/new/

https://reviews.llvm.org/D119606



More information about the llvm-commits mailing list