[PATCH] D119435: [Support][AArch64] Detect a few more host CPU features on AArch64

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 11 15:46:10 PST 2022


nickdesaulniers added inline comments.


================
Comment at: llvm/lib/Support/Host.cpp:1709
                                    .Case("crc32", "crc")
+                                   .Case("atomics", "lse")
+                                   .Case("sve", "sve")
----------------
The Features line of the cpus in my pixel 6 pro have `atomics` (but not sve or sve2). (I don't have an aarch64 host machine for development, yet)

Example:
```
Features        : fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm lrcpc dcpop asimddp
```

to prevent this from getting out of date again, I wonder if we should assert in the default case (and add the rest)?

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/include/uapi/asm/hwcap.h seems to describe these.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119435/new/

https://reviews.llvm.org/D119435



More information about the llvm-commits mailing list