[PATCH] D119580: [LLVM][Support] Delete non-const lvalue ref "copy" constructor of BumpPtrAllocatorImpl

[Zixu Wang via Phabricator via llvm-commits]

zixuw added a comment.

In D119580#3315835 <https://reviews.llvm.org/D119580#3315835>, @JDevlieghere wrote:

> I was curious if the standard specified anything about allocators being copy-constructable. I didn't actually check the standard itself, but cppreference seems to say so: https://en.cppreference.com/w/cpp/named_req/Allocator
>
>> Every Allocator also satisfies CopyConstructible.

Huh. Then I guess the "fix" would actually provide correct copy-constructing behaviors? Currently in this case, the implicit copy-constructor (`BumpAllocatorImpl(const BumpAllocatorImpl &)`) is deleted, and the forwarding constructor provides a match for `BumpAllocatorImpl(BumpAllocatorImpl &)` but does nothing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119580/new/

https://reviews.llvm.org/D119580