[PATCH] D119576: [debug-info] If one sees a spill with a dbg.addr use, salvageDebugInfo upon it and don't hoist it.

Michael Gottesman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 11 14:33:02 PST 2022


gottesmm added a comment.

I noticed that I messed up a comment (see inlined spot). I am going to wait for the testing to finish and then I am going to just update the comment and push (if I can).



================
Comment at: llvm/lib/Transforms/Coroutines/CoroFrame.cpp:2591
   DVI->setExpression(Expr);
-  /// It makes no sense to move the dbg.value intrinsic.
-  if (!isa<DbgValueInst>(DVI)) {
+  // It only makes sense to move the llvm.dbg.value or llvm.dbg.addr intrinsic.
+  if (!isa<DbgValueInst>(DVI) && !isa<DbgAddrIntrinsic>(DVI)) {
----------------
Specifically this comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119576/new/

https://reviews.llvm.org/D119576



More information about the llvm-commits mailing list