[PATCH] D117921: Attributes: add a new allocalign attribute

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/docs/LangRef.rst:1393
+    alignments are permitted for the allocalign parameter, so long as the returned pointer
+    is null.
+
----------------
Should we specify that the attribute may only be applied to integer parameters, and add a corresponding rule to `typeIncompatible()`?


================
Comment at: llvm/lib/Transforms/Utils/CodeExtractor.cpp:906
       // here so we get a warning if new attributes are added.
+      case Attribute::AllocAlign:
       case Attribute::AllocSize:
----------------
This should be in the bottom category (non-function attrs).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117921/new/

https://reviews.llvm.org/D117921