[PATCH] D116769: [ifs] Allow llvm-ifs to generate text stub from elf stub

[Roland McGrath via Phabricator via llvm-commits]

mcgrathr accepted this revision.
mcgrathr added a comment.

lgtm except for possible susceptibility to invalid DT_STRSZ values.
Perhaps there should be a test case for a corrupted PT_DYNAMIC region.



================
Comment at: llvm/lib/InterfaceStub/ELFObjHandler.cpp:382
+    return StringRef(reinterpret_cast<const char *>(*DataOrErr),
+                     DynEnt.StrSize);
+  }
----------------
Is there anything that validates that this size is within the bounds of the memory returned by toMappedAddr?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116769/new/

https://reviews.llvm.org/D116769