[PATCH] D119571: [funcattrs] use DominatorTree to improve noreturn

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/FunctionAttrs.cpp:1618
+static bool canReturn(Function &F) {
+  if (F.empty())
+    return true;
----------------
I don't think this is possible for a function with a definition?


================
Comment at: llvm/lib/Transforms/IPO/FunctionAttrs.cpp:1629-1631
+    if (Visited.contains(BB))
+      continue;
+    Visited.insert(BB);
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119571/new/

https://reviews.llvm.org/D119571