[PATCH] D47895: llvm: Add support for "-fno-delete-null-pointer-checks"

[Manoj Gupta via Phabricator via llvm-commits]

manojgupta added inline comments.


================
Comment at: llvm/trunk/lib/Analysis/InlineCost.cpp:1999
+  // that does not have this attribute.
+  if (!Caller->nullPointerIsDefined() && Callee->nullPointerIsDefined())
+    return llvm::InlineCost::getNever();
----------------
xbolva00 wrote:
> Why not put it to functionsHaveCompatibleAttributes?
I can not not recall why  (this change is > 3 years old ) but it does sound like the right thing to do.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D47895/new/

https://reviews.llvm.org/D47895