[PATCH] D107143: [profile] Fix profile merging with binary IDs

Bo Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 11 08:06:34 PST 2022


hotwinter added a comment.

In D107143#3171287 <https://reviews.llvm.org/D107143#3171287>, @phosek wrote:

> In D107143#3165914 <https://reviews.llvm.org/D107143#3165914>, @glandium wrote:
>
>> Not that it matters anymore after D111123 <https://reviews.llvm.org/D111123> but please note that trunk as of the landing of this (or even trunk before the landing of D111123 <https://reviews.llvm.org/D111123>) says that raw profiles emitted by clang 13.0.0 (which has a backport of this) are malformed.
>
> Can you clarify what exactly is the issue (if any)? What version of Clang are you using?

This looks like to be an issue for me as well, when checking out the `release/13.x` branch at  ToT `75e33f71c2dae584b13a7d1186ae0a038ba98838`, the `binary-id.c` test still fails to run with a this output

  compiler-rt/test/profile/Linux/binary-id.c:47:29: error: BINARY-ID-RAW-PROF-NEXT: expected string not found in input                                                                       
  // BINARY-ID-RAW-PROF-NEXT: Binary IDs:
                              ^                                                                                                                                                                                                                    
  <stdin>:4:32: note: scanning from here                                                                                                                                                                                                           Maximum internal block count: 0                                                                                                                                                                                                                  
                                 ^                                                                                        
                                                                                                                                                                                                                                                   
  Input file: <stdin>                                                                                                                                                                                                                              Check file: compiler-rt/test/profile/Linux/binary-id.c                                                                                                                                     
                                                                                                                                                                                                                                                   
  -dump-input=help explains the following input dump.                                                                                                                                                                                              
                                                                                                                                                                                                                                                   
  Input was:                                                                                                              
  <<<<<<                                                                                                                  
           1: Instrumentation level: Front-end                                                                                                                                                                                                     
           2: Total functions: 3                                                                                          
           3: Maximum function count: 1                                                                                   
           4: Maximum internal block count: 0                                                                                                                                                                                                      
  next:47                                    X error: no match found                                                                                                                                                                               
  >>>>>>                                                    


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107143/new/

https://reviews.llvm.org/D107143



More information about the llvm-commits mailing list