[PATCH] D119266: [SimplifyCFG] Do not merge landingpads for invokes with deopt state.

[Philip Reames via Phabricator via llvm-commits]

reames added a comment.

Reading through the review, I see what look like two related issues.

1. RS4GC expects unique landing pads for calls being wrapped in statepoints.  I don't get why this review phrases this as a property of deopt bundles; this seems like either a) a bug in RS4GC we should just fix or b) a restriction of the abstract machine model (i.e. a function of the GC attribute on the function.)

I'd also think this would be really easy to do in RS4GC as we already have all the utilities for splitting edges.  Assuming there's not a deeper semantic issue I'm missing on first glance, I'd strongly prefer fixing RS4GC.

2. There's a reported infinite loop bug that sounds completely unrelated.  A reproducer for that should be filed as it's own bug asap.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119266/new/

https://reviews.llvm.org/D119266