[PATCH] D117781: [flang] Update tco tool pipline and add translation to LLVM IR

[Andrzej Warzynski via Phabricator via llvm-commits]

awarzynski added a comment.

@mehdi_amini, your approval was indeed conditional and we should've followed-up with a discussion on the future of `tco`. In the past, we only briefly discussed replacing it with `flang-new`. That was a while back, **before** `flang-new` could generate MLIR/LLVM IR/a.out. The situation is a bit different now and it does sound like with a bit of extra work we should be able to replace it with other tools. One major outstanding functionality in `flang-new` is the ability to consume MLIR. We've not really looked into it yet, but I can prioritize it.

Btw, I read @clementval's

> we might change the test to make use of it and maybe retire tco

as:

> it would make sense, but perhaps lets re-visit once upstreaming is complete?

Quite a few tests in `fir-dev` still use `tco` and retiring it now would require people shifting their focus quite a bit. It will be much easier once `fir-dev` is "read-only". Having said that, I think that Valentin has already initiated the transition when he introduced `fir-opt`. To support the transition, I can retrofit `flang-new` to all tests that use `tco` (where possible).  Long term, I do support `tco` being retired unless we can identify a unique feature that we cannot replicate with one of the other tools.

Just my 2p.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117781/new/

https://reviews.llvm.org/D117781