[PATCH] D118354: [AVR][NFC] Fix incorrect register states in expanding pseudo instructions

[Ben Shi via Phabricator via llvm-commits]

benshi001 added inline comments.


================
Comment at: llvm/lib/Target/AVR/AVRExpandPseudoInsts.cpp:2094
+    if (SrcReg != DstLoReg && SrcIsKill)
+      MOV->getOperand(1).setIsKill();
   }
----------------
benshi001 wrote:
> The `SrcReg` should not be set killed when `SrcReg==DstLoReg`.
For example,

`$r19r18 = sext killed $r18`, though the src r18 is killed, but r19r18 is defined and live, so r18 can not be set to killed when expanding the pseudo.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118354/new/

https://reviews.llvm.org/D118354