[PATCH] D117781: [flang] Update tco tool pipline and add translation to LLVM IR

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added a comment.

In D117781#3313606 <https://reviews.llvm.org/D117781#3313606>, @clementval wrote:

> As I mentioned in the chat, we do not have the equivalent of `tco` at this point so it cannot be removed now.

Sure, that part was very clear above. But we also need to agree that:

1. there is a redundancy that isn't justified other than history (you wrote: `nobody took the time to merge the functionality of one into the other yet`)
2. this redundancy is not desirable and so `tco` is meant to disappear.

> Also to make things clearer the `tco` tool is the equivalent of `mlir-translate` in MLIR and `fir-opt` is the equivalent of `mlir-opt`.

This is not clear at all actually, on the contrary: this even goes against the entire discussion in this revision which was about comparing `tco` and `fir-opt`. 
This has nothing to do with `mlir-translate` which is purely about converting from an MLIR dialect to an external representation (basically exporting outside of MLIR), **and nothing else**. In particular `mlir-translate` does not run "MLIR to MLIR" transformations, and does not invoke passes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117781/new/

https://reviews.llvm.org/D117781