[PATCH] D117781: [flang] Update tco tool pipline and add translation to LLVM IR
Mehdi AMINI via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 10 23:49:49 PST 2022
mehdi_amini added a comment.
In D117781#3260512 <https://reviews.llvm.org/D117781#3260512>, @clementval wrote:
> In D117781#3260316 <https://reviews.llvm.org/D117781#3260316>, @mehdi_amini wrote:
>
>> LGTM, **assuming this tool is temporary and will get removed**. But I'd like to understand why the pipeline can't be all registered in `fir-opt`?
>
> I guess we can merge the two tools at some point. `tco` was there before `fir-opt` so nobody took the time to merge the functionality of one into the other yet.
To be very clear in this revision because there seems to be some confusion in the chat:
- You got a conditional LGTM here and you committed based on this condition.
- You acknowledged that you're contributed a tool here that only exists because the functionalities haven't been merged yet to fir-opt, but that we can merge the tools in fir-opt (and so **delete tco** at this point) in the future.
If this isn't very clear, please revert ASAP.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117781/new/
https://reviews.llvm.org/D117781
More information about the llvm-commits
mailing list