[PATCH] D118558: [IVDescriptors] Support FOR where we have multiple sink pointed

[Allen zhong via Phabricator via llvm-commits]

Allen marked 2 inline comments as done.
Allen added a comment.

In D118558#3312344 <https://reviews.llvm.org/D118558#3312344>, @fhahn wrote:

> Oh, and could you double check this version on its own fixes  https://github.com/llvm/llvm-project/issues/53483 if you include it in the commit message?

Yes, it still active for this  test case.



================
Comment at: llvm/lib/Analysis/IVDescriptors.cpp:927
+      const BasicBlock *CurBB = Previous->getParent();
+      if (LastBB != CurBB)
+        return false;
----------------
fhahn wrote:
> might be more compact to just check `LastPrev->getParent() != Previous->getParent()`. 
> 
> 
done


================
Comment at: llvm/lib/Analysis/IVDescriptors.cpp:930
+
+      return Previous->comesBefore(LastPrev);
+    }
----------------
fhahn wrote:
> Maybe add a comment along the lines `If LastPrev comes after the current Previous, SinkCandidate already gets sunk past Previous and there is nothing to do`.
done, much thanks for detail comment content to add.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118558/new/

https://reviews.llvm.org/D118558