[PATCH] D119023: [flang] Adding options to the CfgConversion pass

[Renaud Kauffmann via Phabricator via llvm-commits]

Renaud-K abandoned this revision.
Renaud-K added a comment.

I am not going to submit this patch as I have found out that  it is not legal FIR to have branch based CFG operations inside of block based CFG operations (fir.do_loop, fir.if and fir.iterate_while)



================
Comment at: flang/test/Fir/cfg-options.fir:6
+// RUN: fir-opt %t/if.fir --cfg-conversion="transform-iterate-while=0" | FileCheck %t/if.fir
+// RUN: fir-opt %t/while.fir --cfg-conversion="transform-do-loop=0 transform-if=0" | FileCheck %t/while.fir
+
----------------
mehdi_amini wrote:
> Isn't it a bit more maintainable to have separate files instead?
> 
> They'll show as separate failure if any is failing, it is easier to reproduce issues, and in general long files are annoying to work with.
All this does is testing the plumbing of a few options so it seemed a bit over the top to have 4 different tests. But I guess this is moot since I cannot get split-file to work with pre-check build. I may try again at a later time and add reviewers only once I know it works to avoid the noise. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119023/new/

https://reviews.llvm.org/D119023