[PATCH] D119022: [AMDGPU] Fix debug values in scheduler not placed correctly when reverting

[Austin Kerbow via Phabricator via llvm-commits]

kerbowa added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineScheduler.cpp:927
   }
-  DbgValues.clear();
-  FirstDbgValue = nullptr;
----------------
Does this mean the machine schedule will now iterate through all debug instructions for the function when scheduling each region?


================
Comment at: llvm/lib/Target/AMDGPU/GCNSchedStrategy.cpp:469
+  // pass debug instrs to the actual end of the scheduling region.
+  while (SkippedDebugInstr-- > 0)
+    ++RegionEnd;
----------------
Do we need to specifically track the number of skipped debug instructions, or can we just advance RegionEnd until we stop seeing debug instructions?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119022/new/

https://reviews.llvm.org/D119022