[PATCH] D119394: [lld-macho][nfc] Centralize usages of ld64.lld in tests

[Vy Nguyen via Phabricator via llvm-commits]

oontvoo accepted this revision.
oontvoo added a comment.



In D119394#3309695 <https://reviews.llvm.org/D119394#3309695>, @thevinster wrote:

>> why doesn't re-using %lld plus additional args, which would override the defalut ones provided by %lld anyways, work?
>
> The substitution happens in order and it sees `%lld` within `%lld-noarg` first, so it ends up replacing that whole command and the command ends up failing a whole bunch of tests with `ld64.lld: error: unknown argument '-fatal_warnings-raw'`.

ok, gotcha!

> So, moving that statement up should solve the issue. If the majority feels `%lld-noarg` is a better fit, I'm happy to change it to that; although, isn't noarg technically two words? (So, it should be `%lld-no-arg`?)

On a second thought, I think you have a good point on `%no_arg_lld` , to be consistent with _no_fatal_warning_* .


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119394/new/

https://reviews.llvm.org/D119394